Grpc s2 compression #9292
Closed
Grpc s2 compression #9292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I'll review this when I have some time :) |
|
Taking a look. |
|
I've prototyped dskit support for custom gRPC compressors, and I also have a Mimir PoC adding support for S2 and Snappy compatible S2. Waiting on @pstibrany feedback. |
|
@aknuds1 : Looks good, thanks! |
|
Closed in the favour of #9322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adding GRPC S2 compression for better cross AZ traffic compression, with same CPU and better memory than Snappy.
Which issue(s) this PR fixes or relates to
Fixes #8522
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.