Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suite of e2e tests for new webhook functionality #2691

Open
joeyorlando opened this issue Jul 31, 2023 · 1 comment
Open

Add suite of e2e tests for new webhook functionality #2691

joeyorlando opened this issue Jul 31, 2023 · 1 comment
Assignees
@joeyorlando
Labels
feature request New feature or request more info needed needs triage

Comments

@joeyorlando
Copy link
Contributor

What would you like to see!

Deliverables

  • Add e2e tests which assert that as a user I should be able CRUD new webhooks
  • Add an e2e test(s) which asserts that for a newly created webhook, I can change the status of an Alert Group, and my webhook is properly called. To help with this, you can use something like the ngrok or localtunnel packages to forward traffic to a server endpoint that is spun up in the test environment.

Product Area

Other

Anything else to add?

No response
@joeyorlando joeyorlando added the feature request New feature or request label Jul 31, 2023
@github-actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.19. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@joeyorlando joeyorlando self-assigned this Mar 6, 2024
@joeyorlando joeyorlando mentioned this issue Mar 7, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@joeyorlando @mderynck
cleanup CustomButton backend code + add ngrok/express outgoing …
c5cd675 
…webhook e2e test (#2544)

# What this PR does

- removes unused "custom button" backend code now that we've migrated to
outgoing webhooks
- adds new e2e test for webhooks asserting that an `ngrok`/`express`
webhook handler receives the call as expected + payload is as expected
(related to #2691) - skipped for
now, the test passes locally but fails on GitHub Actions CI, seems to be
networking related
 
## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)

---------

Co-authored-by: Michael Derynck <michael.derynck@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyorlando joeyorlando

Labels
feature request New feature or request more info needed needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iskhakov @joeyorlando