Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom values for Self Hosted Clusters (Slugs, Titles, Region) #4121

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Allow custom values for Self Hosted Clusters (Slugs, Titles, Region) #4121

merged 2 commits into from
Mar 27, 2024

Conversation

elburnetto-intapp
Copy link
Contributor

@elburnetto-intapp elburnetto-intapp commented Mar 27, 2024

What this PR does

Allows for environment variables to be set on Grafana OnCall Engine for Self Hosted users, giving them the ability to set values for Stack Slug, Org Slug/Title, Region & Cluster Slugs.

This will mean then using the Grafana OnCall App, when adding multiple OSS Stacks, you can set the correct value of 'stack_slug' so you can differentiate between the stacks in the App.

Which issue(s) this PR closes

Closes #4119

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@elburnetto-intapp elburnetto-intapp requested a review from a team March 27, 2024 11:54
@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Mar 27, 2024
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution ✌️

@joeyorlando joeyorlando added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@joeyorlando joeyorlando added this pull request to the merge queue Mar 27, 2024
Merged via the queue into grafana:dev with commit 9118ccf Mar 27, 2024
18 checks passed
@elburnetto-intapp elburnetto-intapp deleted the elburnetto-intapp/issue-4119 branch March 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the ability to set custom values for STACK_SLUG in Self Hosted Settings
2 participants