Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot between integration name and alert title in phone call #897

Conversation

Konstantinov-Innokentii
Copy link
Member

What this PR does:
Add dot between integration name and alert title in phone call, to make it more clear

Which issue(s) this PR fixes:
#851

@iskhakov
Copy link
Contributor

Assuming this is for the additional delay
May be we can change the speed of the whole text in twilio?

Copy link

@greatvovan greatvovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the template, I see that the fields are not confused as I originally assumed in #851, but there is probably another factor that contributes to the strange message we hear. What could be an example of integration_name? Can it be not raw name as specified in the UI but contain dots or commas?

@greatvovan
Copy link

greatvovan commented Nov 24, 2022

In this example:
https://soundcloud.com/fun-with-no-end/grafana-oncall-sample-notification
The only variant to disassemble the message is seemingly this:
integration_name = Test web hook
title = Congratulations
alert_count = 1

But how to explain the value of integration_name? The value configured in the UI was just "Test". Can it come as "Test, web hook" or "Test. Web hook" by chance? How otherwise explain the pause between "test" and "web hook"?

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this change or here is my proposal:

"That's Grafana OnCall. Escalation (title) from integration (integration name) triggered (alert count) times."

@greatvovan
Copy link

As per discussion in #851, a part of the problem is that integration_name is not really integration name, but (integration name + type). In my opinion, they should not be concatenated and must be passed into the template as independent fields, to have a freedom of composing the message.

@greatvovan
Copy link

For example, I would like it to hear as "Alert via {integration_type} integration {integration_name}, title {title}, triggered {alert_count} times". Currently we do not have such a freedom. Also no accounting for singular/plural form of "time".

Templated example: "Alert via Prometheus integration Production cluster, title CPU usage, triggered 1 time".

@Konstantinov-Innokentii
Copy link
Member Author

Stale

@joeyorlando joeyorlando deleted the separate_integration_and-alertgroup_title_phone_call branch March 17, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants