-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dot between integration name and alert title in phone call #897
Add dot between integration name and alert title in phone call #897
Conversation
Assuming this is for the additional delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the template, I see that the fields are not confused as I originally assumed in #851, but there is probably another factor that contributes to the strange message we hear. What could be an example of integration_name
? Can it be not raw name as specified in the UI but contain dots or commas?
In this example: But how to explain the value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve this change or here is my proposal:
"That's Grafana OnCall. Escalation (title) from integration (integration name) triggered (alert count) times."
As per discussion in #851, a part of the problem is that |
For example, I would like it to hear as "Alert via {integration_type} integration {integration_name}, title {title}, triggered {alert_count} times". Currently we do not have such a freedom. Also no accounting for singular/plural form of "time". Templated example: "Alert via Prometheus integration Production cluster, title CPU usage, triggered 1 time". |
Stale |
What this PR does:
Add dot between integration name and alert title in phone call, to make it more clear
Which issue(s) this PR fixes:
#851