Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Commit 33986e6

Browse files
committed
wait for /ready instead of hitting the ui directly
1 parent 8565aa6 commit 33986e6

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/e2e.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: Cypress run
3333
uses: cypress-io/github-action@v5
3434
with:
35-
wait-on: http://localhost:4100/ui/
35+
wait-on: http://localhost:4100/ready
3636
start: make run
3737
config-file: cypress/ci.ts
3838
env:
@@ -64,7 +64,7 @@ jobs:
6464
- name: Cypress run
6565
uses: cypress-io/github-action@v5
6666
with:
67-
wait-on: http://localhost:8080/foobar/
67+
wait-on: http://localhost:8080/ready
6868
start: |
6969
make run PARAMS=-api.base-url=/foobar/
7070
config-file: cypress/ci-base-path.ts

pkg/frontend/frontend.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,9 @@ func NewFrontend(cfg Config, limits Limits, log log.Logger, reg prometheus.Regis
168168
}
169169

170170
func (f *Frontend) starting(ctx context.Context) error {
171+
// Artificial delay
172+
time.Sleep(time.Second * 60)
173+
171174
f.schedulerWorkersWatcher.WatchService(f.schedulerWorkers)
172175

173176
return errors.Wrap(services.StartAndAwaitRunning(ctx, f.schedulerWorkers), "failed to start frontend scheduler workers")

0 commit comments

Comments
 (0)