This repository was archived by the owner on Jul 19, 2023. It is now read-only.
feat: timelines #635
Merged
feat: timelines #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Apr 19, 2023
cyriltovena
reviewed
Apr 20, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Add support for timelines Also: * The resolution calculation is heavily inspired by Grafana's (https://github.com/grafana/grafana/blob/bc11a484ed97d9c87e8dd42347c2c34713e9e441/pkg/tsdb/intervalv2/intervalv2.go#L1), which is more fine grained compared to OG Pyroscope's (https://github.com/grafana/pyroscope/blob/d7ed25ebb6c50a7eab906666933d48e71573d3e8/pkg/storage/segment/constants.go#L7-L24) * Grafana's implementation uses the frontend size as a hint on how many points to calculate. Since OG Pyroscope doesn't do that (and changing it would require some effort), I am hardcoding a default, which can be revised later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support timelines:
Couple points:
Since OG Pyroscope doesn't do that (and changing it would require some effort), I am hardcoding a default, which can be revised later.