This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Datasource: Query editor autocomplete #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrapereira
approved these changes
Aug 19, 2022
| }, [] as Label[]); | ||
|
|
||
| // Check if we are editing a label value right now. If so also get name of the label | ||
| const matchLabelValue = text.substring(0, offset).match(/(\w+)=("?)[^"]*$/); |
There was a problem hiding this comment.
This regex won't match labels that include dots .. Not sure if it's possible for them to have dots in fire but I ran into this issue for tempo.
For example http.status_code only matched status_code with this regex and it results in the autocomplete value being empty.
Same issue in line 179.
A quick fix is to replace (\w+) at the start with ([\w.]+).
There was a problem hiding this comment.
hmm @cyriltovena can there be dots in the label names?
There was a problem hiding this comment.
https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels names no ! but value yes possibly.
There was a problem hiding this comment.
Thanks. Yeah going to change the regex according to prom spec
8 tasks
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Datasource: Query editor autocomplete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple autocomplete for the query editor:
Future considerations: