Docs: Add Ratings functionality #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
type/docs
jackw
requested review from
oshirohugo,
tolzhabayev and
sympatheticmoose
and removed request for
a team
jackw
force-pushed
the
jackw/docs-rating
branch
from
38cc492
to
cd9f0db
Compare
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
tolzhabayev
reviewed
Aug 7, 2024
| @@ -74,6 +74,12 @@ const config = { | |||
| sdkUrl: 'https://rsdk.grafana.com', | |||
| }, | |||
| canSpamUrl: 'https://grafana-dev.com/canspam', | |||
| faroConfig: { | |||
| url: '/connect/af1fca71911a9641ebdffddb56889e97', | |||
There was a problem hiding this comment.
I think this is a production key, I don't think there is one for dev
tolzhabayev
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a Ratings component to allow users to give feedback on how useful they find a page on our docs site.
The main docs website uses faro which I've brought across for the ride. I'm not sure if the behaviour is correct that faro is only setup and sends measurements if the cookies are agreed to (same as rudderstack).
What does it look like:
Original buttons state:
Once rated buttons state:
Which issue(s) this PR fixes:
Fixes #1006
Special notes for your reviewer: