-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugin: Introduce OS check #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🚀 PR was released in |
I have created a grafana container in my local docker and could login in grafana UI ,I have plan to create a react plugin .when I write this command(npx @grafana/create-plugin@latest
However, when I write the npx command in ubuntu and I get the error! |
@atefehsafarkhah Could you please run this command in the same terminal you are trying to run create plugin and tell us the output (even if an error)? We did tests with windows machines and all of them worked as expected. It is very important to differentiate between having WSL installed and running commands inside WSL. |
@atefehsafarkhah thanks for coming back to me so fast. could you please run this command in the exact same terminal you get that output from In all the tests we've done we always get |
@academo Yes, my output is also Linux . my node version is: v12.22.9 |
What this PR does / why we need it:
Adds a check to the bin file that exits early if windows powershell or command prompt is detected when running commands. Tested by running the following code on a windows VM:
Results
Windows Command Prompt
Windows PowerShell
Windows WSL
Which issue(s) this PR fixes:
Related #239
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@1.6.0-canary.263.16338d8.0 # or yarn add @grafana/create-plugin@1.6.0-canary.263.16338d8.0
Release Notes
create-plugin
will now exit when run natively on Windows, which is an unsupported platform with known issues. By exiting early we hope to prevent users from hitting issues whilst developing plugins. We recommend the use of Windows Subsystem for Linux (WSL) which is supported.