-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create-plugin: Refactor getTemplateData to be used in generate command and update commands #837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @Ukochka. This is looking good. I've left a nit and a couple of questions around the proxy usage.
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Joe Perez <joseph.perez@grafana.com>
This reverts commit 3b26a98.
Co-Authored-By: Yulia Shanyrova <yulia.shanyrova@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work on this @Ukochka 👏
Co-Authored-By: Yulia Shanyrova <yulia.shanyrova@grafana.com>
🚀 PR was released in |
What this PR does / why we need it:
After removing Plop another way to getting template data was introduced and it is a duplication of getTemplate data we already had. We need to unify getting template data for all the commands: generate, migrate, update, provisioning
After refactoring: getTemplateData returns TemplateData object. It takes data from User prompt for generate command and from package.json for other commands
Which issue(s) this PR fixes:
Fixes #82
Special notes for your reviewer:
I merged changes from this PR, which fixes #758
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.9.1-canary.837.e9165e7.0 npm install @grafana/plugin-e2e@1.2.1-canary.837.e9165e7.0 # or yarn add @grafana/create-plugin@4.9.1-canary.837.e9165e7.0 yarn add @grafana/plugin-e2e@1.2.1-canary.837.e9165e7.0