Create-plugin: Refactor getTemplateData to be used in generate command and update commands #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukochka
added
create-plugin
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Joe Perez <joseph.perez@grafana.com>
This reverts commit 3b26a98.
Co-Authored-By: Yulia Shanyrova <yulia.shanyrova@grafana.com>
leventebalogh
approved these changes
Apr 29, 2024
Co-Authored-By: Yulia Shanyrova <yulia.shanyrova@grafana.com>
leventebalogh
added
release
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After removing Plop another way to getting template data was introduced and it is a duplication of getTemplate data we already had. We need to unify getting template data for all the commands: generate, migrate, update, provisioning
After refactoring: getTemplateData returns TemplateData object. It takes data from User prompt for generate command and from package.json for other commands
Which issue(s) this PR fixes:
Fixes #82
Special notes for your reviewer:
I merged changes from this PR, which fixes #758
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.9.1-canary.837.e9165e7.0 npm install @grafana/plugin-e2e@1.2.1-canary.837.e9165e7.0 # or yarn add @grafana/create-plugin@4.9.1-canary.837.e9165e7.0 yarn add @grafana/plugin-e2e@1.2.1-canary.837.e9165e7.0