-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Plugin E2E - Panel plugin docs #852
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have edited this document in https://github.com/grafana/plugin-tools/pull/852/commits. Please take a look and ensure that no errors have been introduced.
Looks good, thanks Joe! |
Co-authored-by: Joe Perez <joseph.perez@grafana.com>
What this PR does / why we need it:
This PR adds a guide on how to e2e test panel plugins. Feedback on parts that are missing are very much welcome!
I feel like we should say something about the complexity that comes with testing visual components such as lines and curves, and why we discourage screenshot testing. At the same time, I want plugin authors to be free to chose whatever path they think is right. WDYT?
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: