Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Plugin E2E - Panel plugin docs #852

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Apr 3, 2024

What this PR does / why we need it:

This PR adds a guide on how to e2e test panel plugins. Feedback on parts that are missing are very much welcome!

I feel like we should say something about the complexity that comes with testing visual components such as lines and curves, and why we discourage screenshot testing. At the same time, I want plugin authors to be free to chose whatever path they think is right. WDYT?

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link

github-actions bot commented Apr 3, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@sunker sunker added the no-changelog Don't include in changelog and version calculations label Apr 3, 2024
@sunker sunker marked this pull request as ready for review April 3, 2024 10:56
@sunker sunker requested a review from a team as a code owner April 3, 2024 10:56
@sunker sunker requested review from oshirohugo, sympatheticmoose, josmperez and mckn and removed request for a team April 3, 2024 10:56
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this

Copy link
Contributor

@josmperez josmperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have edited this document in https://github.com/grafana/plugin-tools/pull/852/commits. Please take a look and ensure that no errors have been introduced.

@sunker
Copy link
Contributor Author

sunker commented Apr 9, 2024

I have edited this document in https://github.com/grafana/plugin-tools/pull/852/commits. Please take a look and ensure that no errors have been introduced.

Looks good, thanks Joe!

@sunker sunker merged commit 0153d27 into main Apr 9, 2024
20 checks passed
@sunker sunker deleted the plugin-e2e/panel-plugin-docs branch April 9, 2024 06:29
Ukochka pushed a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Joe Perez <joseph.perez@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Don't include in changelog and version calculations
Projects
Development

Successfully merging this pull request may close these issues.

3 participants