Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godeltaprof: Support Go 1.22 #86

Closed
Tracked by #157782
stefanb opened this issue Dec 27, 2023 · 1 comment
Closed
Tracked by #157782

godeltaprof: Support Go 1.22 #86

stefanb opened this issue Dec 27, 2023 · 1 comment

Comments

@stefanb
Copy link

stefanb commented Dec 27, 2023

godeltaprof build tags in internal/ specify Go behaviour only up to 1.21, not including the upcoming Go 1.22:
https://github.com/grafana/pyroscope-go/tree/main/godeltaprof/internal/pprof

Please add support also for Go 1.22

Eg, a test build with Go 1.22

reported:

  # github.com/pyroscope-io/godeltaprof/internal/pprof
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/pyroscope-io/godeltaprof@v0.1.2/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/pyroscope-io/godeltaprof@v0.1.2/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

In this case the reference to the new go module location is being updated in

but this will not solve the Go 1.22 support until it is added here.

@stefanb
Copy link
Author

stefanb commented Dec 27, 2023

Ah, i found

so this should be already taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant