-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: relax internals stub build tag to golang 1.22 #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
we also need tip tests in this repo
@olegbespalov note we (I?) did not run on tip any tests, but I expect it should work fine there as I am not aware of any changes in the golang runtime which could affect godeltaprof. I pushed godeltaprof/v0.1.5 tag |
@korniltsev Yeah, I've pushed the tests separately #57 |
Do you want me to open the PR for the compact, or are you going to do this by-yourself? |
I dont understand the question. Im probably missing something. What's left to be done for compat? |
Locally, my compact tests failed since an old version was also pinned https://github.com/grafana/pyroscope-go/blob/main/godeltaprof/compat/go.mod#L7 |
I'm confused. How is it different from the gh actions? gh actions are green. Updating it here anyways #58 |
I'm confused too 😅 Let me investigate why it so |
* Bump grafana/pyroscope-go to v0.1.6 to support Go 1.22 Support for Go 1.22 was added in grafana/pyroscope-go#55 * Update CHANGELOG.md
* Bump grafana/pyroscope-go to v0.1.6 to support Go 1.22 Support for Go 1.22 was added in grafana/pyroscope-go#55 * Update CHANGELOG.md
What?
Relax the internal stub build tag for golang 1.22 (which is the current tip)
Why?
Otherwise, tests on tip could fail, and example: https://github.com/grafana/k6/actions/runs/6422397110/job/17438798642?pr=3370