Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax internals stub build tag to golang 1.22 #55

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

olegbespalov
Copy link
Contributor

What?

Relax the internal stub build tag for golang 1.22 (which is the current tip)

Why?

Otherwise, tests on tip could fail, and example: https://github.com/grafana/k6/actions/runs/6422397110/job/17438798642?pr=3370

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we also need tip tests in this repo

@korniltsev korniltsev merged commit 1c04c88 into grafana:main Oct 6, 2023
7 checks passed
@korniltsev
Copy link
Collaborator

@olegbespalov note we (I?) did not run on tip any tests, but I expect it should work fine there as I am not aware of any changes in the golang runtime which could affect godeltaprof.

I pushed godeltaprof/v0.1.5 tag

@olegbespalov
Copy link
Contributor Author

olegbespalov commented Oct 6, 2023

@korniltsev Yeah, I've pushed the tests separately #57

@olegbespalov
Copy link
Contributor Author

I pushed godeltaprof/v0.1.5 tag

Do you want me to open the PR for the compact, or are you going to do this by-yourself?

@korniltsev
Copy link
Collaborator

Do you want me to open the PR for the compact, or are you going to do this by-yourself?

I dont understand the question. Im probably missing something. What's left to be done for compat?

@olegbespalov
Copy link
Contributor Author

olegbespalov commented Oct 6, 2023

Locally, my compact tests failed since an old version was also pinned

https://github.com/grafana/pyroscope-go/blob/main/godeltaprof/compat/go.mod#L7

@korniltsev
Copy link
Collaborator

I'm confused. How is it different from the gh actions? gh actions are green.

Updating it here anyways #58

@olegbespalov
Copy link
Contributor Author

I'm confused too 😅

Let me investigate why it so

tpaschalis pushed a commit to grafana/agent that referenced this pull request Jan 15, 2024
* Bump grafana/pyroscope-go to v0.1.6 to support Go 1.22

Support for Go 1.22 was added in grafana/pyroscope-go#55

* Update CHANGELOG.md
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
* Bump grafana/pyroscope-go to v0.1.6 to support Go 1.22

Support for Go 1.22 was added in grafana/pyroscope-go#55

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants