Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(godeltaprof): remove go build upper bound tag for runtime_expandFinalInlineFrame runtime_cyclesPerSecond #95

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix(godeltaprof): remove go build upper bound tag for runtime_expandFinalInlineFrame runtime_cyclesPerSecond #95

merged 2 commits into from
Jan 22, 2024

Conversation

korniltsev
Copy link
Collaborator

We run tests on gotip, so I think we dont need this build tag at all

This fixes build on gotip

#94

@korniltsev korniltsev marked this pull request as draft January 22, 2024 05:03
@korniltsev
fix(godeltaprof): remove go build upper bound tag for runtime_expandF…
573bdf0 
…inalInlineFrame runtime_cyclesPerSecond links
@korniltsev korniltsev marked this pull request as ready for review January 22, 2024 05:23
kolesnikovae
kolesnikovae approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 7be6ef6 into main Jan 22, 2024
8 checks passed
@JacobOaks JacobOaks mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae