-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update import paths to use .js file extensions #89
Conversation
👋 Hey @zckrs! Thanks for this contribution. I just merged some lint changes (requiring semicolons) which created a lot of conflicts with this PR. I also ran CI on this PR and it looks like specifying |
Hi @bryanhuhta 👋 I just rebase on main and reapply diff How can I help you to merge this ? |
@zckrs I appreciate your patience 🙇 I validated this patch works on both a ESM project and a CJS one, but the test suite does not appreciate these changes. When I run the tests, I get lots of
Presumably because there is a mismatch between how jest is configured to resolve modules and how the modules are built. I've been trying to find a solution, but my free time is limited. The only blocker to this change is making sure the test suite can run with these changes in place. |
In fact Jest doesn't have a good support for ESM :/ |
@bryanhuhta since it seems like Jest is the blocker here, would y'all welcome a PR to rewrite the tests with Mocha, Vitest, or some other test runner of your choice that better supports modern JS features like ESM? |
I went ahead and opened #94 to migrate to Vitest. Hopefully that can unblock proper ESM support. |
I tested these changes locally on top of the latest Very excited to see this land. @bryanhuhta if @zckrs can't resolve the conflicts soon, you should be able to do so on his behalf and get this merged. If not, I'd (selfishly) suggest opening a new PR with conflicts resolved so that the next release isn't blocked. |
Hi, |
@zckrs @nwalters512 I merged this and released |
To follow #32, #33 and fix build for ESM