Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes annotation detection is inacurate in high resolutions #1505

Closed
eh-am opened this issue Sep 14, 2022 · 0 comments · Fixed by #1510
Closed

Closes annotation detection is inacurate in high resolutions #1505

eh-am opened this issue Sep 14, 2022 · 0 comments · Fixed by #1510

Comments

@eh-am
Copy link
Collaborator

eh-am commented Sep 14, 2022

Kapture 2022-09-14 at 16 27 27

Compared to a higher resolution (~1 hour):
Kapture 2022-09-14 at 16 29 53

Most likely due to an inaccuracy from flot's pointOffset function

Testing data

❯ curl -X POST -d '{ "appName": "pyroscope.server.cpu", "content": "test", "timestamp": 1663182385 }' localhost:4040/api/annotations

http://localhost:4040/?query=pyroscope.server.cpu%7B%7D&from=1663182345&until=1663182410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant