feat(webapp): annotations UI #1489
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.31% // Head: 66.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 66.31% 66.62% +0.31%
==========================================
Files 139 143 +4
Lines 4755 4843 +88
Branches 1288 1306 +18
==========================================
+ Hits 3153 3226 +73
- Misses 1597 1612 +15
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/create-server |
|
Long term I think it would be cool to make these annotations look something like this: Where there are multiple "types" depending on the type of annotations |
| timestamp: number | ||
| ) { | ||
| const f = annotations.find( | ||
| (a) => Math.abs(a.timestamp - timestamp) < THRESHOLD |
There was a problem hiding this comment.
as I understand you've added THRESHOLD to have kind of distance of watching markings, but does it the same for all markings? how does it work you have 3 annotations near each other? for example, on timestamps 15:30:25, 15:30:27, 15:30:28?
There was a problem hiding this comment.
that's a great point actually, i didn't think of this at all, let me see what i can do
There was a problem hiding this comment.
added a solution, although not perfect, hopefully will fix in #1505
There was a problem hiding this comment.
@eh-am, this problem might be a bit deeper, I have no idea why, but these annotation marks (#1505) looks like vertical selection lines in left/right timelines on ComparisonView page. Just take look at them more attentively. Dotted line + black draggable area. I added this appearance only for left/right single timeline selection lines, is there chance you pass some incorrect props? any kind of props conflict? But no idea what they are doing in annotations PR.
…pe into feat/annotations-ui
|
/create-server |
|
/create-server |
4 participants
Render annotations created via the backend (creating annotation via UI will come in a new PR):
There's still some visual glitches that I would like to address (in separate PRs) before considering this feature done:
To create an annotation
You can get the current timestamp with
date +%s