Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds proper support for goroutines, block, mutex profiling #1178

Merged
merged 7 commits into from
Jun 27, 2022

Conversation

petethepig
Copy link
Member

@petethepig petethepig commented Jun 25, 2022

Corresponding PR on the client side: grafana/pyroscope-go#15

To enable this in pull mode:

scrape-configs:
  - job-name: testing
    enabled-profiles: [cpu, mem, goroutines, mutex, block]

Caveat is that mutex and block profiling requires an extra step:

runtime.SetMutexProfileFraction(5)
runtime.SetBlockProfileRate(5)

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1178 (52fa36b) into main (7247cf5) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   69.41%   69.37%   -0.04%     
==========================================
  Files          98       98              
  Lines        3210     3212       +2     
  Branches      836      837       +1     
==========================================
  Hits         2228     2228              
- Misses        978      980       +2     
  Partials        4        4              
Impacted Files Coverage Δ
...raph/src/FlameGraph/FlameGraphComponent/Header.tsx 90.91% <0.00%> (ø)
packages/pyroscope-flamegraph/src/format/format.ts 69.47% <0.00%> (-1.07%) ⬇️
packages/pyroscope-models/src/flamebearer.ts 60.72% <ø> (ø)
packages/pyroscope-models/src/profile.ts 91.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7247cf5...52fa36b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 467.16 KB (0%) 9.4 s (0%) 2 s (+0.17% 🔺) 11.4 s

Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +68 to +69
// TODO(petethepig): technically block profiles have the same name
// so this might be a block profile, need better heuristic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, it won't be a big problem: in pull mode we have a correct mapping, while push API allows specifying it in an explicit way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants