Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PHP support via phpspy #157

Merged
merged 3 commits into from
May 17, 2021
Merged

Adds PHP support via phpspy #157

merged 3 commits into from
May 17, 2021

Conversation

petethepig
Copy link
Member

@petethepig petethepig commented Apr 19, 2021

TODO:

Instructions

These are instructions on how to test changes in this PR

Setup

  • clone pyroscope repo
git clone https://github.com/pyroscope-io/pyroscope
  • clone phpspy library repo
git clone https://github.com/pyroscope-io/phpspy

Test Changes

To test changes you make in phpspy repo:

  • first, build phpspy library:
cd phpspy
docker build . --tag pyroscope/phpspy:dev
  • second, build a new pyroscope version:
cd pyroscope
docker build . --tag pyroscope/pyroscope:dev
  • third, build and run the example application with the new pyroscope version:
cd pyroscope/examples/php
docker-compose build && docker-compose up

@petethepig petethepig changed the title First steps towards integrating phpspy into pyroscope Adds PHP support via phpspy Apr 19, 2021
@petethepig petethepig mentioned this pull request Apr 19, 2021
@petethepig petethepig closed this May 16, 2021
@petethepig petethepig reopened this May 16, 2021
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@e098d77). Click here to learn what that means.
The diff coverage is 66.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage        ?   57.29%           
=======================================
  Files           ?       73           
  Lines           ?     2938           
  Branches        ?        0           
=======================================
  Hits            ?     1683           
  Misses          ?     1112           
  Partials        ?      143           
Impacted Files Coverage Δ
pkg/agent/session.go 63.94% <ø> (ø)
pkg/agent/spy/spy.go 5.00% <0.00%> (ø)
pkg/analytics/analytics.go 83.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e098d77...97203ca. Read the comment docs.

@petethepig petethepig merged commit 16f2bff into main May 17, 2021
@petethepig petethepig deleted the phpspy branch May 17, 2021 07:26
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Flamegraph: Use data from datasource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant