-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rideshare memory leak #2641
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 added one note on adjusting parameters
- PARAMETERS_POOL_SIZE=10000 | ||
- PARAMETERS_POOL_BUFFER_SIZE_KB=10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusting the sizes here will work when running locally, but in order to get these to reflect in sedemo, you'll need to update them here. There's additional knobs to tune there as well. The memory limit is 64Mi per pod, so using sizes this big would OOM those pods right away.
Of course, if this is just intended to be shown with a local version of the rideshare demo then adjusting these settings will but 👌
Adding memory for example purposes
builds off of #2640 and #2632 and #2610 but makes the leak more visible