Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase parquet read buffer size #2924

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Increase parquet read buffer size #2924

merged 1 commit into from
Jan 15, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Jan 15, 2024

Page sizes for parquet files tent to be larger than the current read buffer which results in more page reads than ideal. This change increases the size from 256KB to 2MB. In tests against a GCS backed storage this yields around 5-10% improved response time for the SelectMergeByStacktraces API and in a synthetic test with higher latencies towards the object store gains of up to 20% can be observed.

@cyriltovena

@aleks-p aleks-p requested a review from a team as a code owner January 15, 2024 12:50
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleks-p aleks-p merged commit cea7b25 into main Jan 15, 2024
19 checks passed
@aleks-p aleks-p deleted the reduce-querier-page-reads branch January 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants