Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebpf: fix elf base for unaligned PT_LOAD offset, make build id error not fatal #2983

Merged
merged 9 commits into from
Feb 5, 2024
Merged

ebpf: fix elf base for unaligned PT_LOAD offset, make build id error not fatal #2983

merged 9 commits into from
Feb 5, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Feb 2, 2024 •
edited
Loading

  • fix finding elf base address for unaligned PT_LOAD offset
555e3d192000-555e3d1ac000 r--p 00000000 00:3e 1824988                    /smoketest
555e3d1ac000-555e3d212000 r-xp 00019000 00:3e 1824988                    /smoketest
555e3d212000-555e3d218000 r--p 0007e000 00:3e 1824988                    /smoketest
555e3d218000-555e3d219000 rw-p 00083000 00:3e 1824988                    /smoketest
555e3d219000-555e3d424000 rw-p 00000000 00:00 0 

                                                                                      

Elf file type is DYN (Position-Independent Executable file)
Entry point 0x1a1a0
There are 12 program headers, starting at offset 64

Program Headers:
  Type           Offset             VirtAddr           PhysAddr
                 FileSiz            MemSiz              Flags  Align
  LOAD           0x0000000000000000 0x0000000000000000 0x0000000000000000
                 0x0000000000019194 0x0000000000019194  R      0x1000
  LOAD           0x00000000000191a0 0x000000000001a1a0 0x000000000001a1a0
                 0x0000000000064ee0 0x0000000000064ee0  R E    0x1000
  LOAD           0x000000000007e080 0x0000000000080080 0x0000000000080080
                 0x0000000000005928 0x0000000000005928  RW     0x1000
  LOAD           0x00000000000839b0 0x00000000000869b0 0x00000000000869b0
                 0x0000000000000300 0x000000000020a764  RW     0x1000
  TLS            0x000000000007e080 0x0000000000080080 0x0000000000080080
                 0x0000000000000a48 0x0000000000000a48  R      0x8

                 0x000000000001a1a0 - 0x00000000000191a0
  • Make build id parsing not fatal

@korniltsev korniltsev changed the title ebpf: fix findning elf base address for unaligned PT_LOAD offset ebpf: fix finding elf base address for unaligned PT_LOAD offset Feb 2, 2024
@korniltsev korniltsev changed the title ebpf: fix finding elf base address for unaligned PT_LOAD offset ebpf: fix elf base for unaligned PT_LOAD offset, make build id error not fatal Feb 3, 2024
cyriltovena
cyriltovena reviewed Feb 5, 2024
View reviewed changes
ebpf/symtab/elf.go Outdated Show resolved Hide resolved
cyriltovena
cyriltovena approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev @cyriltovena
Update ebpf/symtab/elf.go
ab193c0 
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
@korniltsev korniltsev enabled auto-merge (squash) February 5, 2024 14:08
@korniltsev korniltsev merged commit 5f808d3 into main Feb 5, 2024
19 checks passed
@korniltsev korniltsev deleted the log-debugging branch February 5, 2024 14:14
@korniltsev korniltsev mentioned this pull request Feb 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @cyriltovena