Fix bug in query frontend diff handling #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
commented
May 24, 2024
This also adds some test coverage to the query-frontend diff handler.
simonswine
force-pushed
the
20240524_fix-frontend-panic
branch
from
8aa7d5b
to
0fd9ac9
Compare
simonswine
changed the title
aleks-p
approved these changes
May 28, 2024
simonswine
added a commit
that referenced
this pull request
May 28, 2024
This also adds some test coverage to the query-frontend diff handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic, that could happen when one of the query results in the diff are empty.
Also adds some more coverage to the Diff handler in the frontend.
Note: We should pull this into f68.