Deploy trusting client-provided trace IDs by default #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
changed the title
roobre
changed the title
roobre
force-pushed
the
deploy-trust-tracing
branch
from
19728c9
to
b137882
Compare
|
@Blinkuu For some reason I cannot add you as a reviewer, so FYI :) |
Blinkuu
approved these changes
Aug 28, 2023
dgzlopes
approved these changes
Aug 28, 2023
roobre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19 introduced an environment variable that, when set, instructs QuickPizza to trust TraceIDs arriving to user-accessible endpoints, instead of generating new ones.
This PR enables this behavior by default, which is very reasonable for demo purposes. Moreover, the variable has also been renamed to
QUICKPIZZA_TRUST_CLIENT_TRACEID, which hopefully will convey the same meaning while being slightly less alarming to see in the Docker CLI.