Scenes performance: Measurement #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
added
patch
5 tasks
dprokop
commented
Sep 26, 2024
| } | ||
|
|
||
| // Will calculate total time spent on Network | ||
| function calculateNetworkTime(requests: PerformanceResourceTiming[]): number { |
dprokop
commented
Sep 26, 2024
|
|
||
| // Wraps an arbitrary Promise in an observble that emits Promise state | ||
| export function wrapPromiseInStateObservable(promise: Promise<any>): Observable<QueryResultWithState> { | ||
| console.log('wrapPromiseInStateObservable', promise); |
There was a problem hiding this comment.
Suggested change
| console.log('wrapPromiseInStateObservable', promise); |
dprokop
commented
Sep 26, 2024
| @@ -46,3 +46,30 @@ export function registerQueryWithController<T extends QueryResultWithState>(entr | |||
| }); | |||
| }; | |||
| } | |||
|
|
|||
| // Wraps an arbitrary Promise in an observble that emits Promise state | |||
| export function wrapPromiseInStateObservable(promise: Promise<any>): Observable<QueryResultWithState> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/grafana/hyperion-planning/issues/69
Read about the details in https://docs.google.com/document/d/1AXnxWJju0xS4zZWZUlFPONPKbMpEUYDHqvx0av3SyvE/edit?usp=sharing
📦 Published PR as canary version:
5.14.8--canary.858.10850008598.0✨ Test out this PR locally via:
npm install @grafana/scenes-react@5.14.8--canary.858.10850008598.0 npm install @grafana/scenes@5.14.8--canary.858.10850008598.0 # or yarn add @grafana/scenes-react@5.14.8--canary.858.10850008598.0 yarn add @grafana/scenes@5.14.8--canary.858.10850008598.0