Implementing structured logs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
force-pushed
the
dannykopping/structured_logs
branch
from
da3d05a
to
4727b11
Compare
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
force-pushed
the
dannykopping/structured_logs
branch
from
4727b11
to
04e7486
Compare
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
|
|
||
| log.WithField("err_code", err.Code). | ||
| WithField("err_msg", err.Msg). | ||
| WithField("uuid", uniqueID). |
There was a problem hiding this comment.
like the idea of uuid to tie together the logs for a request.
questions:
- will it be indexed by loki?
- if yes, how do we tell loki to not index it?
seems like loki doesn't like high cardinality labels grafana/loki#91
There was a problem hiding this comment.
Yeah, I'm assuming the logs will get shipped to Loki.
The UUID won't be indexed because of the issue you correctly pointed out.
However, I've included the UUID in all log entries related to the mail send path, so if an error occurs in any step we can correlate all logs from that request by doing something like {app="smtprelay"} | json | uuid="..." to find all the additional details
added 2 commits
February 10, 2021 12:20
Defaulting to stdout Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Refactoring Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3