Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions migrated to sqlutil #107

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

njvrzm
Copy link
Contributor

@njvrzm njvrzm commented Jan 19, 2024

This updates sqlds to use functionality migrated to sqlutil, most recently in grafana/grafana-plugin-sdk-go#862. Some aliases are left behind for backwards compatibility, marked as deprecated - those can be removed in a future release.

This resolves #85; it depends on grafana/grafana-plugin-sdk-go#862.

@njvrzm njvrzm linked an issue Jan 19, 2024 that may be closed by this pull request
@njvrzm njvrzm marked this pull request as ready for review January 19, 2024 14:04
@njvrzm njvrzm requested a review from a team as a code owner January 19, 2024 14:04
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya! Will let @iwysiu weigh-in since she's more familiar, but I love that there's no breaking changes for consumers of this package, nice work!

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Another reminder to remove the replace line from go.mod and a suggestion on formatting the deprecation warnings

macros.go Outdated Show resolved Hide resolved
@njvrzm njvrzm removed the request for review from a team January 22, 2024 19:18
@njvrzm njvrzm force-pushed the 85-update-to-sqlutil-helpers branch from 9bdc18f to 6b0b5ec Compare January 24, 2024 08:14
@njvrzm njvrzm merged commit 71090eb into main Jan 24, 2024
3 checks passed
@njvrzm njvrzm deleted the 85-update-to-sqlutil-helpers branch January 24, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to sqlutil helpers
3 participants