Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple connections setup #49

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Fix multiple connections setup #49

merged 2 commits into from
Oct 22, 2021

Conversation

andresmgot
Copy link
Collaborator

Fixes #48

  • Changes the key to store db connections to use the DatasourceID as prefix.
  • Move the datasource settings to the connections map (so it's not global to the sqldatasource instance).

@andresmgot andresmgot mentioned this pull request Oct 22, 2021
Closed
@andresmgot andresmgot merged commit 7dafc4b into main Oct 22, 2021
@andresmgot andresmgot deleted the fixDbConn branch October 22, 2021 14:52
@andresmgot andresmgot mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminehart kminehart kminehart approved these changes

@sunker sunker Awaiting requested review from sunker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple connections appear to be broken
2 participants
@andresmgot @kminehart