drop bearerTokenSecret assert in e2e-openshift/monitoring test #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
cc @IshwarKanse |
|
@andreasgerstmayr Yeah, not sure what changed, the test case is passing when run from our forked repo, used by our OCP CI job, which is behind by 34 commits. However the case fails when run from the parent repo even on a non CRC cluster. I'm fine with the assert change as it doesn't affect the functionality. |
IshwarKanse
approved these changes
Nov 20, 2023
Merged
pavolloffay
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert is not required (please correct me if I'm missing something).
The test fails on CRC without this change.