Allow resource limits overrides #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
force-pushed
the
issue_726_resources_override
branch
from
24b6c0d
to
f71dd47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 73.82% 73.95% +0.12%
==========================================
Files 84 84
Lines 6197 6227 +30
==========================================
+ Hits 4575 4605 +30
Misses 1393 1393
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Co-authored-by: Andreas Gerstmayr <andreas@gerstmayr.me>
rubenvp8510
force-pushed
the
issue_726_resources_override
branch
from
a81b21d
to
4ebd28a
Compare
rubenvp8510
force-pushed
the
issue_726_resources_override
branch
from
4ebd28a
to
5252719
Compare
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
andreasgerstmayr
approved these changes
Feb 12, 2024
|
Thank you for this work 💪🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726
This is the first step on providing some enhancements to the resources, this at least will provide some flexibility for the users that are not comfortable using the formula.
This doesn't change anything on the formula side, it will directly override the component resources. and won't touch the rest of the components at all.