Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oapi-codegen check #129

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix oapi-codegen check #129

merged 1 commit into from
Apr 17, 2023

Conversation

spinillos
Copy link
Member

Oapi-codegen was forked inside the library and it has a bug that it isn't able to detect that a duplicate field is the same. Mainly because its checking two pointers with equal operator.

This was reported and a PR was created in their repository to fix that bug.

@spinillos spinillos changed the title Fix buggy check Fix oapi-codegen check Apr 17, 2023
Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdboyer sdboyer merged commit 99b482c into main Apr 17, 2023
mildwonkey pushed a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants