Allow unify references #154
Conversation
|
Each datasource is generating its own DataQuery struct... I understand that its something expected. |
Yes, this is expected, at least for now. We'll soon need to deal with controls that allow us to generate these as references to imported types, similar to what we do in TS. |
| if hasSubpath { | ||
| for i, sel := range gen.cfg.Subpath.Selectors() { | ||
| if !val.Allows(sel) { | ||
| return nil, errors.Newf(cuetil.FirstNonThemaPos(val), "subpath %q not present in schema", cue.MakePath(gen.cfg.Subpath.Selectors()[:i+1]...)) |
There was a problem hiding this comment.
just an aside - i expect we'll see more of this kind of "make thema an invisible passthrough" logic in the future - both in error output like in this case, but also when we get into references and we need the special Thema helpers that enable reference declarations to be invisible to code generators
| } | ||
|
|
||
| // Afoo defines model for afoo. | ||
| type Afoo struct { | ||
| External | ||
| Extfield string `json:"extfield"` |
There was a problem hiding this comment.
This is weird. But also, what i originally committed is weird. The nilcfg output here seems sanest - it just makes the type of AFoo a reference to Foo. And it seems like that's what this should be - type Afoo Foo.
Looking at it makes me think we need clarity on what references vs. unifications are supposed to mean in the context of generated Go code, so that we have a clear rule to apply in the context of each set of options here.
So, weird though this is, let's treat it as a follow-up.
When we extend an interface with another interface, the reference is inside
allOftag of open-api schema.Knowing that, we can move these values into a properties to render the interfaces instead their inner values. For any reason, if we don't have references, exists a default empty one that we needed to skip here.
Also, the current library implementation forces to set a type and json tag to every element and its the reason of the rest of the changes in this PR.
When we set group or expandref we aren't unable to find the reference of the interfaces and we have to put the inner interface values instead: here and here.
Update: We have a known issue with new flattern pattern where we are unable to find some references when we use
_#schemadefinition. Using _join and schema individually fixes the issue.