thema: Try to return a concrete result from #Translate #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
reviewed
May 18, 2023
| @@ -174,8 +174,10 @@ func (i *Instance) Translate(to SyntacticVersion) (*Instance, TranslationLacunas | |||
| lac := make(multiTranslationLacunas, 0) | |||
| out.LookupPath(cue.MakePath(cue.Str("lacunas"))).Decode(&lac) | |||
|
|
|||
| raw, _ := out.LookupPath(cue.MakePath(cue.Str("result"), cue.Str("result"))).Default() | |||
There was a problem hiding this comment.
this is...slightly bizarre, let's make sure to add a comment indicating why the Default() call is there. Especially given that this is tightly coupled to the current implementation approach for #Translate
There was a problem hiding this comment.
Sure! Comment added!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a call to
Default()after calling the CUE#Translateto try to return a concrete result, and deal with inconsistently-shaped instances fromTranslateandValidate, as described in #155.It also adds a regression test specifically checking what's described on the issue.
Fixes #155