Improve TextContent null element detection
#1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
added
enhancement
inancgumus
changed the title
TextContent null element detection
inancgumus
force-pushed
the
improve/get-attribute-null-detection
branch
from
359cb96
to
a348af1
Compare
inancgumus
force-pushed
the
improve/text-content-null-detection
branch
from
7b14f71
to
b987414
Compare
This was referenced Jun 6, 2024
Base automatically changed from
improve/get-attribute-null-detection
to
main-async
June 6, 2024 15:22
The commit is long because these components are interconnected.
inancgumus
force-pushed
the
improve/text-content-null-detection
branch
from
b987414
to
770f2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
TextContentmethods now returnfalsewhen the element's text content cannot be grabbed (like a JSdocument). I've added tests only forElementHandleas the other types have theirTextContenttests.Why?
Previously, these methods returned an empty string (
""). That approach makes it impossible to distinguish between whether the text content is missing or empty.Checklist
Related PR(s)/Issue(s)
#428