Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: readme invalid header #99

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: readme invalid header #99

merged 1 commit into from
Aug 23, 2023

Conversation

kamontat
Copy link
Contributor

@kamontat kamontat commented Aug 22, 2023 •
edited
Loading

Link on line 27 doesn't work because heading is not matches.

xk6-kubernetes/README.md

Line 27 in 693426d

The `xk6 build` command creates a k6 binary that includes the xk6-kubernetes extension in your local folder. This k6 binary can now run a k6 test using [xk6-kubernetes APIs](#apis).

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javaducky javaducky self-requested a review August 23, 2023 15:03
javaducky
javaducky approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@javaducky javaducky merged commit 789ffcf into grafana:main Aug 23, 2023
7 checks passed
@kamontat kamontat deleted the main-1 branch August 25, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javaducky javaducky javaducky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamontat @CLAassistant @javaducky