Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewPublicKey in verifier.go #516

Open
treyridley opened this issue May 21, 2020 · 0 comments
Open

Update NewPublicKey in verifier.go #516

treyridley opened this issue May 21, 2020 · 0 comments
Assignees

Comments

@treyridley
Copy link
Contributor

The PublicKey struct needs to have signature algorithm in order for PKIX and JWT verification to work. PublicKey has been updated to hold this field but NewPubicKey() needs to be updated to take a signature algorithm and add that to the field of the PublicKey instance it is creating.

The change also requires updates everywhere NewPublicKey is used.

@treyridley treyridley self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant