Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataClient for Open Source Grafeas #4

Merged
merged 9 commits into from
Nov 18, 2020
Merged

MetadataClient for Open Source Grafeas #4

merged 9 commits into from
Nov 18, 2020

Conversation

lynnsh
Copy link
Collaborator

@lynnsh lynnsh commented Nov 11, 2020

This PR will:

  • create rest calls to grafeas open source v1beta1 version used by MetadataClient
  • create objects to receive and send data used by rest calls (links to similar client-go objects are included in comments)
  • add gomock for grafeas open source client tests
  • add grafeas open source option to cmd/config MetadataClient setup

Steps to test with a real copy of Grafeas:

  • start local grafeas server
  • add testing data to the server (either with curl and json or by using GrafeasApiService and createAllOccurrences in client_test)
  • test using curl requests or update client_test to use GrafeasApiService configured to call your local grafeas server

@google-cla
Copy link

google-cla bot commented Nov 11, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lynnsh
Copy link
Collaborator Author

lynnsh commented Nov 11, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Nov 11, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 11, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dani-santos-code
Copy link
Collaborator

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Nov 11, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dani-santos-code
Copy link
Collaborator

@googlebot I consent

Copy link
Collaborator

@catherinejones catherinejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this in Shopify's codebase and I think everything is good to go!

@lynnsh lynnsh merged commit e1ccb5a into grafeas:main Nov 18, 2020
@lynnsh lynnsh deleted the grafeasos-aline branch November 18, 2020 21:28
thepwagner added a commit that referenced this pull request Jun 1, 2022
docker/schema2: support manifest lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants