Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3 suppport #1

Closed
IvanAnishchuk opened this issue Jan 18, 2017 · 12 comments · Fixed by #2
Closed

Add Python 3 suppport #1

IvanAnishchuk opened this issue Jan 18, 2017 · 12 comments · Fixed by #2

Comments

@IvanAnishchuk
Copy link

Isn't it, like, 2017 already? A few workarounds will be needed needed to support both py2 nd py3 but, actually, pure py3 code would've been simpler because bytes essentially is a byte array, no map(ord, ...) needed.

@graham
Copy link
Owner

graham commented Jan 23, 2017

agreed, i'll make the changes and update (old habits die hard).

@graham
Copy link
Owner

graham commented Jan 23, 2017

Relevant change from https://github.com/mguentner graham/base32hex@57b12c5

@silkentrance
Copy link
Contributor

@graham I created a PR for this, see #2 for more information

@graham
Copy link
Owner

graham commented Aug 4, 2017 via email

@xulei890817
Copy link

It's a nice lib,small and pretty,
and i still need python3 support.

@graham graham closed this as completed in #2 Aug 18, 2017
graham added a commit that referenced this issue Aug 18, 2017
@graham
Copy link
Owner

graham commented Aug 18, 2017

Thanks to a077857 @silkentrance -> python 3 is now supported.

@silkentrance
Copy link
Contributor

@xulei890817 python 2 and 3 are now supported

@askogvold
Copy link

@graham Could this be released as a new version on PyPI as well? latest=1.0.4, which does not have this update

Thanks for the library!

@silkentrance
Copy link
Contributor

@askogvold what is the problem with the fixes made by the PR? any issues with that?

@askogvold
Copy link

@silkentrance no, nothing wrong with the fixes, it's great that it works on both now. - Just suggesting a release on PyPI.

@silkentrance
Copy link
Contributor

@askogvold see #3 which targets your inquiry, sort of 😁

@askogvold
Copy link

😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants