Removed Move Scene #131
Merged
Removed Move Scene #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this for iOS gesture but it doesn’t work for that because there’s more to iOS gesture - like title moving along with gesture. Can’t replicate this so removing move scene because it complicates the code for no benefit. The only way to replicate iOS gesture is with native swift code so will think about adding this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'moveScene' was only there for the swipe back gesture on iOS. But this gesture is more complicated than moving the scene because it also moves titles and blurs them. The only way to replicates this is with native code. Will think about creating custom swift module for iOS later. For now, just removing
moveSceneto avoid confusion and simplify code