Changed from Browserify to Rollup #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed default export and directly exported inidividual classed and
interfaces. Means that var Navigation = require('navigation') works the
same in node
Typescript 2 added support for es3 target and es6 module. This is what makes rollup work with typescript - need typescript to compile to es3 and rollup to remove the es6 modules
Seems faster than browserify
Tests didn't work without it
Can't remember why needed this. It was some workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used TypeScript 2.0 in order to target ES3, to keep cross browser support, with ES6 Modules, which Rollup needs. Used default exports on internal modules, but not on Navigation and NavigationReact so that the public Api is unchanged.
Rollup saves anywhere between 10% and 20% off the built file sizes. The gzipped navigation.js is under 6kb.