Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resolve strategy DELEGATE_FIRST => OWNER_FIRST #13257

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

guillermocalvo
Copy link
Contributor

Fixes #13250

Since the closure's resolve strategy was changed to DELEGATE_FIRST, thisObject.beanTypeResolver is no longer updated by the next assignment in SpringSecurityCoreGrailsPlugin:

beanTypeResolver = beanTypeResolverClass.newInstance(conf, grailsApplication)

Instead, the assignment is intercepted by BeanBuilder.setProperty and then discarded because currentBeanConfig is null:

public void setProperty(String name, Object value) {
  if (currentBeanConfig != null) {
    setPropertyOnBeanConfig(name, value);
  }
}

@puneetbehl I'm not sure what's the specific problem that we were trying to solve in #13150, so please let me know if you think using OWNER_FIRST here makes more sense than using DELEGATE_FIRST.

@guillermocalvo guillermocalvo linked an issue Dec 6, 2023 that may be closed by this pull request
@puneetbehl puneetbehl merged commit c48fa44 into 5.3.x Dec 6, 2023
7 checks passed
@puneetbehl puneetbehl deleted the fix-plugin-delegate-strategy branch December 6, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Spring Security plugin in 5.3.4
2 participants