Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grails-quartz feature #322

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: grails-quartz feature #322

merged 2 commits into from
Mar 21, 2024

Conversation

guillermocalvo
Copy link
Contributor

@guillermocalvo guillermocalvo commented Mar 18, 2024 •
edited
Loading

This PR fixes a bug introduced by #276

@guillermocalvo guillermocalvo mentioned this pull request Mar 18, 2024
Merged
matrei
matrei approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
But there seem to be a general timeout running the tests in CI (not because of this PR).

@matrei
Copy link
Contributor

matrei commented Mar 19, 2024

I have now created a PR (#324) that fixes the problem with failing tests.
Maybe merge #324 first and then rebase this one to see the tests pass before merging?

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@matrei matrei merged commit bad4c8e into 6.2.x Mar 21, 2024
11 checks passed
@guillermocalvo guillermocalvo deleted the fix/quartz-feature branch March 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrei matrei matrei approved these changes

@puneetbehl puneetbehl Awaiting requested review from puneetbehl

Assignees
No one assigned
Labels
bug feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guillermocalvo @matrei @CLAassistant @grails-build