Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow unsafe wasm values in globals #519

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Jan 31, 2021

This PR adds the global use functionality described in #517.

@ospencer ospencer requested a review from a team January 31, 2021 03:55
@ospencer ospencer self-assigned this Jan 31, 2021
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from mutable-globals to main February 4, 2021 16:30
@ospencer ospencer force-pushed the allow-unsafe-wasm-vals-in-globals branch from 1b175af to 0848b6e Compare February 4, 2021 16:36
@ospencer ospencer merged commit 111b549 into main Feb 4, 2021
@ospencer ospencer deleted the allow-unsafe-wasm-vals-in-globals branch February 4, 2021 17:01
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants