fix(stdlib): Remove fd_sync calls that are not used #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
Sep 2, 2021
| | None => | ||
| failwith( | ||
| Printf.sprintf( | ||
| "Unable to locate `%s` in your polyfill. Required by `%s`", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between #800 being submitted and merged, we also landed some changes to the stdlib that changed the calling convention in non-GC contexts. This required adding some
fd_syncimports for debugging and they didn't get removed, which caused the linker to fail on our wasi polyfill tests.Here, I've added a better error message for this case and then removed the 2 references to fd_sync in our stdlib, so the tests should pass again.