-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grainfmt): Removed a trailing comma after a spread in a list, and fixed escaped single quote #923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change after #926 ?
I think it looks better on the same line anyway, so I'd leave it as is. |
author's original intention
Working now #930 is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let it rock!
Adding a comma after a spread in a list was a syntax error
[a,...b,]
Keep array set assignments on the same line as the =
Use constants direct from source to avoid losing any programmer intention regarding structure/format e.g. keep chars specified in the same format, numbers in the same base, etc.