fix(grainfmt): Removed a trailing comma after a spread in a list, and fixed escaped single quote #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Sep 25, 2021
I think it looks better on the same line anyway, so I'd leave it as is. |
phated
reviewed
Sep 25, 2021
author's original intention
|
Working now #930 is fixed |
peblair
reviewed
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a comma after a spread in a list was a syntax error
[a,...b,]
Keep array set assignments on the same line as the =
Use constants direct from source to avoid losing any programmer intention regarding structure/format e.g. keep chars specified in the same format, numbers in the same base, etc.