feat(stdlib): Add Conv.wasmI32ToNumber function #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Oct 11, 2021
phated
reviewed
Oct 11, 2021
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
phated
reviewed
Oct 11, 2021
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
ospencer
approved these changes
Oct 11, 2021
| // the same. This may sound counter intuitive, but for numbers that fit into | ||
| // the range it is faster than performing the check with WasmI32.geS and | ||
| // WasmI32.leS by about 20%. An additional ~33% is gained by avoiding a | ||
| // call to tagSimpleNumber and instead doing it inline. For the case of |
There was a problem hiding this comment.
I've got some branches in the works that makes Binaryen inlining of these calls work, so no worries about that in the future 🙂
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to convert WasmI32 to Number. This differs from
tagSimpleNumberin runtime/dataStructures in that it's safe to use for any value of WasmI32, not just the range allowed in Simple numbers.Btw there's also
tagSimplein runtime/numbes that duplicates exactly the code fromtagSimpleNumber, or the other way around. Maybe one can become reexport of the other.I tried to optimize it so that we can possibly just replace most uses of
tagSimpleNumber/tagSimplewithout fearing performance regressions.