-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pal] Remove STATIC_SLAB flag #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @pwmarcz)
-- commits, line 4 at r1:
I don't think it's "anymore", it's like "never really worked". This is from the Chia-Che times :)
Pal/include/pal_defs.h, line 5 at r1 (raw file):
/* maximum length of URIs */ #define URI_MAX 4096
Now that we have only one macro in this file, can we just move this file somewhere else and remove this header file altogether?
But if you think it's orthogonal to this PR, I will resolve.
Pal/src/slab.c, line 30 at r1 (raw file):
static void* g_high = &g_mem_pool[POOL_SIZE]; #else #define ALLOC_ALIGNMENT g_slab_alignment
Heh, looks like this macro was never used
d34b30c
to
f6d7941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 52 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
I don't think it's "anymore", it's like "never really worked". This is from the Chia-Che times :)
OK. Changed.
Pal/include/pal_defs.h, line 5 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Now that we have only one macro in this file, can we just move this file somewhere else and remove this header file altogether?
But if you think it's orthogonal to this PR, I will resolve.
And URI_MAX
probably belongs in pal.h
anyway.
Removed. It looks like we included that file everywhere, but sed /pal_defs.h/d
took care of things.
Pal/src/slab.c, line 30 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Heh, looks like this macro was never used
It was a parameter to slabmgr.h
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 52 of 52 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 52 of 52 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
PAL never really worked without STATIC_SLAB. Signed-off-by: Paweł Marczewski <pawel@invisiblethingslab.com>
f6d7941
to
b2e1aab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
PAL doesn't work without STATIC_SLAB anymore.
(As discussed in #32).
How to test this PR?
Jenkins should be enough, there are no functional changes.
This change is