Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compiler target for the ES2015 build from esnext to ES2015 #80

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

drakosvlad
Copy link
Contributor

As it turned out, current Focal's ES6-build is not ES6-compliant and is not supported in some older browsers (e.g. Legacy MS Edge). This happens because of the build script misconfiguration – the build target provided to the tsc is esnext. Because of that, some of the more recent language features (e.g. Object literal spread operator) appear in the ES6 build. This MR changes the build target to the expected one for the ES6 build.

Copy link
Member

@blacktaxi blacktaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@blacktaxi blacktaxi merged commit e053b6e into grammarly:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants