New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hydrate Chat and User #18

Merged

KnorpelSenf merged 18 commits into main from 15-chat-and-user

Oct 14, 2023

Contributor

roziscoding commented Jun 30, 2023

Closes #15

Rogério Munhoz added 7 commits

June 29, 2023 13:27


          chore: fix broken VSCode config

3ce97d5


          chore: update deno2node


          chore: remove @grammyjs/types dependency

8cafbb1


          feat: hydrate user

4ea8e8f


          chore: set default formatter on VSCode config

c276e60


          wip: hydrate chat

8e9b500


          chore: create hydrated method snippet

b08969a

roziscoding added enhancement help wanted labels

roziscoding requested review from KnightNiwrem and dcdunkan

June 30, 2023 15:46


          fix: only hydrate user and chat on api results

f954b18

roziscoding marked this pull request as ready for review

July 4, 2023 12:53

roziscoding requested a review from KnorpelSenf

July 4, 2023 12:54

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved


          chore: change UserX import order

1d498f1

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved


          fix: remove chat and user from chatJoinRequest

8a22695

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved


          fix: remove extra character

6bf327d

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved

roziscoding commented

View reviewed changes

src/data/chat-join-request.ts Outdated Show resolved Hide resolved

roziscoding and others added 3 commits

July 4, 2023 09:58


          chore: remove unused imports

c74ed93


          chore: remove more unnecessary hydrations

6076b6f


          chore: untouch unrelated files

1f2bf93

KnorpelSenf requested changes

View reviewed changes

deno.jsonc Outdated Show resolved Hide resolved

src/deps.node.ts Outdated Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

src/plugin.ts Show resolved Hide resolved

roziscoding and others added 3 commits

July 8, 2023 14:08


          chore: remove unnecessary comment

f61a7ab

Co-authored-by: KnorpelSenf <shtrog@gmail.com>


          chore: pin version of d2n

83ec240


          chore: import types as types

858b434

KnorpelSenf requested changes

View reviewed changes

.vscode/shortcuts.code-snippets Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

KnorpelSenf approved these changes

View reviewed changes

Member

KnorpelSenf left a comment

LGTM apart from the inconsistencies with imports

Member

KnorpelSenf commented Jul 11, 2023

@KnightNiwrem @dcdunkan perhaps you guys still wanna TAL, I didn't test this


          chore: update type imports and remove linter comment

04a7f07

Contributor Author

roziscoding commented Oct 11, 2023

Guys, can we merge this?

KnightNiwrem approved these changes

View reviewed changes

Contributor

KnightNiwrem left a comment

TRUST

KnorpelSenf merged commit eb0370e into main

KnorpelSenf deleted the 15-chat-and-user branch

October 14, 2023 09:32

Member

KnorpelSenf commented Dec 30, 2023

How is this still unreleased? That will happen today then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement help wanted