Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Scaling Up IV #800

Merged
merged 30 commits into from
Jun 30, 2023
Merged

Rewrite Scaling Up IV #800

merged 30 commits into from
Jun 30, 2023

Conversation

KnorpelSenf
Copy link
Member

Closes #795.

@KnorpelSenf KnorpelSenf requested a review from rojvv June 17, 2023 14:25
@github-actions
Copy link

github-actions bot commented Jun 17, 2023

@github-actions github-actions bot temporarily deployed to pull request June 17, 2023 14:29 Inactive
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
Co-authored-by: Roj <ez@roj.im>
@github-actions github-actions bot temporarily deployed to pull request June 17, 2023 15:34 Inactive
@KnorpelSenf KnorpelSenf requested a review from rojvv June 17, 2023 15:40
Co-authored-by: Roj <ez@roj.im>
@github-actions github-actions bot temporarily deployed to pull request June 17, 2023 20:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 17, 2023 20:38 Inactive
@rojvv rojvv changed the title feat: rewrite scaling up iv Rewrite Scaling Up IV Jun 17, 2023
site/docs/advanced/flood.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 15:51 Inactive
Ese plugin es [muy simple](https://github.com/grammyjs/auto-retry/blob/main/src/index.ts).
Literalmente sólo duerme y reintenta.
Sin embargo, usarlo tiene una implicación mayor: **cualquier petición puede ser lenta**.
Esto significa que cuando ejecutas tu bot con webhooks, [técnicamente tienes que usar una cola](../guide/deployment-types.md#ending-webhook-requests-in-time) hagas lo que hagas, o bien tienes que configurar el plugin auto-retry de forma que nunca tarde mucho tiempo---pero entonces tu bot puede saltarse algunas peticiones.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong anchor

Цей плагін [дуже простий](https://github.com/grammyjs/auto-retry/blob/main/src/index.ts).
Він буквально просто чекає й повторює спроби.
Однак його використання має серйозні наслідки: **будь-який запит може сповільнюватися**.
Коли ви запускаєте свого бота на вебхуках, це означає, що [технічно ви повинні використовувати чергу](../guide/deployment-types.md#ending-webhook-requests-in-time) незалежно від того, що ви робите, або що вам потрібно налаштувати плагін `auto-retry` так, щоб він ніколи не займав багато часу, але тоді ваш бот може пропустити виконання деяких запитів.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong anchor

@quadratz
Copy link
Contributor

Seems the check links is not working properly?

@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 23:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 23:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 23:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 24, 2023 00:05 Inactive
@quadratz quadratz added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label Jun 24, 2023
@quadratz quadratz requested a review from a user June 24, 2023 00:09
@github-actions github-actions bot temporarily deployed to pull request June 24, 2023 00:10 Inactive
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Jun 27, 2023
@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 21:53 Inactive
@KnorpelSenf KnorpelSenf requested a review from rojvv June 30, 2023 11:01
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docsy!

@rojvv rojvv dismissed quadratz’s stale review June 30, 2023 19:24

Internal decision

@rojvv rojvv merged commit 933c32d into main Jun 30, 2023
@rojvv rojvv deleted the flood branch June 30, 2023 19:24
@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 19:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated load docs
10 participants